Re: [Qemu-devel] EXT3-fs error on Git HEAD

[Frank Arnold]

Am Dienstag, den 30.06.2009, 11:07 +0200 schrieb Kevin Wolf:
> Frank Arnold schrieb:
> > commit ad53089b0d0b4bc0731d978e5713365e1a91ba74
> > Author: Christoph Hellwig <address@hidden>
> > Date:   Mon May 25 15:45:37 2009 +0200
> > 
> >     qcow: add qcow_aio_setup helper
> 
> This one has an obvious bug. Does the following change help?
> 
> diff --git a/block/qcow.c b/block/qcow.c
> index 55a68a6..7fc85ae 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -723,7 +723,7 @@ static BlockDriverAIOCB
> *qcow_aio_writev(BlockDriverState *bs,
> 
>      s->cluster_cache_offset = -1; /* disable compressed cache */
> 
> -    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 0);
> +    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 1);
>      if (!acb)
>          return NULL;

Yes, this change seems to fix it. The guest survived 3 hours of stress
testing and the image was still intact.
Tested on top of kvm-87-71-g6179556 (qemu-kvm.git).

Thanks for looking into it.
-- 
Frank Arnold <address@hidden>
System Design Technician, Software Test
AMD Operating System Research Center
Dresden, Germany
Tel: +49 351 448 356702


Legal Information:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34
85609 Dornach b. München

Geschäftsführer: Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis München
Registergericht München, HRB Nr. 43632