|
From: | Jes Sorensen |
Subject: | [Qemu-devel] Re: [patch 1/2] Introduce -smp , maxcpus= flag to specify maximum number of CPUS. |
Date: | Wed, 24 Jun 2009 11:02:48 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 |
On 06/24/2009 11:02 AM, Avi Kivity wrote:
On 06/24/2009 11:35 AM, Jes Sorensen wrote:Follow on patch will use it to determine the size of the MADT and other BIOS tables. +int max_cpus = 16;Again I should have noticed this before, but this and the other constants should come from the QEMUMachine we're targeting, since each target has different limits.
Actually this is on purpose. The PC machine has a max limit of 255, if we use that as the max per default, you are going to get a BIOS declaring 255 possible CPUs and certain broken operating systems are not going to boot. So I will argue the code is correct as is. Cheers, Jes
[Prev in Thread] | Current Thread | [Next in Thread] |