Re: [Qemu-devel] [PATCH] replace duplicated code.

[Gerd Hoffmann]

> -            dev = qdev_create(&bus->qbus, pci_nic_names[i]);
> -            qdev_set_prop_int(dev, "devfn", devfn);
> -            qdev_set_prop_ptr(dev, "name", (void *)pci_nic_names[i]);
> -            qdev_set_netdev(dev, nd);
> -            qdev_init(dev);

> +            d = pci_create_simple(bus, devfn, pci_nic_names[i]);
> +            qdev_set_netdev((DeviceState *)d, nd);

You have changed the ordering of the qdev_set_netdev and qdev_init 
calls.  I don't think this is correct, the init callback will not see 
the nicinfo then.

cheers,
  Gerd