|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH v2] alsa: fix warning |
Date: | Thu, 18 Jun 2009 08:27:53 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 06/17/09 20:15, malc wrote:
On Wed, 17 Jun 2009, Gerd Hoffmann wrote:Signed-off-by: Gerd Hoffmann<address@hidden> --- audio/alsaaudio.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 2f6c764..f1d573a 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@ -626,8 +626,9 @@ static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as) req.period_size = conf.period_size_out; req.buffer_size = conf.buffer_size_out; req.size_in_usec = conf.size_in_usec_out; - req.override_mask = !!conf.period_size_out_overridden - | (!!conf.buffer_size_out_overridden<< 1); + req.override_mask = + (conf.period_size_out_overridden ? 1 : 0) | + (conf.buffer_size_out_overridden ? 2 : 0);[..snip..] What warning does that fix?
CC audio/alsaaudio.o cc1: warnings being treated as errors /home/kraxel/projects/qemu/audio/alsaaudio.c: In function ‘alsa_init_out’:/home/kraxel/projects/qemu/audio/alsaaudio.c:630: error: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
/home/kraxel/projects/qemu/audio/alsaaudio.c: In function ‘alsa_init_in’:/home/kraxel/projects/qemu/audio/alsaaudio.c:710: error: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
make: *** [audio/alsaaudio.o] Error 1 cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |