[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] avoid compilation warning/errors on up to date
Re: [Qemu-devel] [PATCH] avoid compilation warning/errors on up to date compilers
Tue, 16 Jun 2009 23:07:51 +0200
KMail/1.11.2 (Linux/2.6.28-13-generic; KDE/4.2.2; x86_64; ; )
Le mardi 16 juin 2009 22:56:43 Anthony Liguori, vous avez écrit :
> Stuart Brady wrote:
> > On Tue, Jun 16, 2009 at 06:03:43PM +0300, Riku Voipio wrote:
> >> Which tree against did you make these changes? the qemu-ndb.c bit didn't
> >> apply against HEAD. Also, there are some whitespace/tab issues. See the
> >> CODING_STYLE doc. Functionally I can verify it removes compiler warnings
> >> when using a modenr glibc (2.9).
> > Unfortunately, some of the changes don't look right.
> I think adding -D_FORTIFY_SOURCE=1 to CFLAGS is probably a better fix
> than adding broken error handling everywhere.
If the error handling I am proposing is not perfect at least it does something
instead of being non existent.
Is it really considered as a better solution to just ignore what the people
maintaining gcc/glibc consider should not be ignored?
> Anthony Liguori