Re: [Qemu-devel] [PATCH] Register usb-uhci reset function.

[Gleb Natapov]

On Tue, Jun 16, 2009 at 02:19:44PM -0500, Anthony Liguori wrote:
> Gleb Natapov wrote:
>> Update irq line on reset. Reseting irq line is required because
>> racing irq from pci device will call piix3_set_irq(). piix3_set_irq()
>> will remember current level in pci_irq_levels[]. The PIC line will be
>> triggered if one of pci_irq_levels[] is set (depends on piix3 config).
>> If for instance pci_irq_levels[0] and pci_irq_levels[1] are mapped to
>> the same PIC irq and during reset pci_irq_levels[1] == 1, but device
>> that drives pci_irq_levels[0] is initialized first the device driver
>> will not be able to lower irq line.
>>
>> Without this patch RHEL4.8 hangs after reboot because usb interrupt
>> does not go away.
>>   
>
> This breaks the build because...
>
>> @@ -346,6 +346,7 @@ static void uhci_reset(UHCIState *s)
>> +    qemu_register_reset(uhci_reset, 0, s);
>>   
> qemu_register_reset takes void (*)(void *) and you're passing void  
> (*)(UHCIState *).
>
Tested it before -Werror :)

--
                        Gleb.