[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Regression opening read-only cdroms
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] Regression opening read-only cdroms |
Date: |
Tue, 16 Jun 2009 21:37:30 +0300 |
On 6/16/09, Blue Swirl <address@hidden> wrote:
> On 6/16/09, Avi Kivity <address@hidden> wrote:
> > qemu used to be quite happy opening read-only cdrom images, and I was quite
> > happy feeding kvm-autotest a library of read-only iso images. However
> since
> >
> > commit 0e1d8f4c549e51fd19793a154862979fdc199477
> > Author: Christoph Hellwig <address@hidden>
> > Date: Mon Jun 15 13:53:26 2009 +0200
> >
> > raw-posix: always store open flags
> >
> > Both the Linux floppy and the FreeBSD CDROM host device need to
> > store
> > the open flags so that they can re-open the device later. Store
> > the
> > open flags unconditionally to remove the ifdef mess and simply the
> > calling conventions for the later patches in the series.
> >
> > Signed-off-by: Christoph Hellwig <address@hidden>
> >
> > this state of happiness no longer exists.
> >
> > Can you look at what caused this?
>
>
> How about these:
> - open_flags = O_BINARY;
> + s->open_flags |= O_BINARY;
> - open_flags = O_BINARY;
> + s->open_flags |= O_BINARY;
Fix attached, could you test it?
0001-Fix-opening-of-read-only-raw-images.patch
Description: Source code patch
- Re: [Qemu-devel] Regression opening read-only cdroms, (continued)
Re: [Qemu-devel] Regression opening read-only cdroms, Richard W.M. Jones, 2009/06/18
Re: [Qemu-devel] Regression opening read-only cdroms, Blue Swirl, 2009/06/16
- Re: [Qemu-devel] Regression opening read-only cdroms,
Blue Swirl <=