[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [Qemu-commits] [COMMIT 95bed64] Fix a warning: uint_fas
From: |
Paul Brook |
Subject: |
[Qemu-devel] Re: [Qemu-commits] [COMMIT 95bed64] Fix a warning: uint_fast8_t is not 8 bits onOpenBSD/Sparc64 |
Date: |
Sat, 13 Jun 2009 19:53:24 +0100 |
User-agent: |
KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; ) |
> > > + asid = env->tlb->mmu.r4k.tlb[i].ASID;
> > > + qemu_put_8s(f, &asid);
> >
> > Wouldn't it be simpler to just use qemu_put_byte?
>
> uint_fast8_t equals uint32_t on OpenBSD/Sparc64. It's also big endian,
> so qemu_put_byte(f, &env->tlb->mmu.r4k.tlb[i].ASID) writes the MSB
> (==0).
Not even close. qemu_put_byte works by value, not by reference. i.e. you want
qemu_put_byte(f, env->tlb->mmu.r4k.tlb[i].ASID);
Paul
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] Re: [Qemu-commits] [COMMIT 95bed64] Fix a warning: uint_fast8_t is not 8 bits onOpenBSD/Sparc64,
Paul Brook <=