[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] qdev: very first cut of scsi bus support.
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] qdev: very first cut of scsi bus support. |
Date: |
Fri, 12 Jun 2009 12:22:45 +0100 |
User-agent: |
KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; ) |
On Friday 12 June 2009, Gerd Hoffmann wrote:
> +
> + if (bus) {
> + d = scsi_create_simple(bus, "scsi-disk");
> + } else {
> + /* temporary until usb is qdev-ified */
> + d = (SCSIDevice *)qemu_mallocz(sizeof(SCSIDevice));
>+static void scsi_disk_initfn(SCSIDevice *dev)
>+{
>+ /* TODO */
>+}
These are both fairly good indicators that this patch is nowhere near ready
for integration. The whole point of the qdev API is to abstract device
creation from individual device implementation details. Your implementation
has the abstraction layers completely backwards.
The I2C code is an example of how a secondary bus should work.
Paul