[Qemu-devel] Re: [Qemu-commits] [COMMIT 3dcd219] Update irqs on reset and device load

[Paul Brook]

On Tuesday 09 June 2009, Anthony Liguori wrote:
> From: Blue Swirl <address@hidden>
>@@ -3314,6 +3314,8 @@ static int rtl8139_load(QEMUFile* f,void* opaque,int
> version_id) s->cplus_enabled = s->CpCmd != 0;
>     }
>
>+    rtl8139_update_irq(s);

This should not be necessary.

PCI bus multiplexers should save/restore their own internal state.

In fact this patch only works by chance, and relies on the fact that the bus 
multiplexers have no temporal state.

Paul