Re: [Qemu-devel] [PATCH] exec-migration: handle EINTR in popen_get_buffer()

[Uri Lublin]

On 06/08/2009 07:55 PM, Blue Swirl wrote:
> On 6/8/09, Uri Lublin<address@hidden>  wrote:
> > Sometimes, upon interrupt, fread returns with no data, and
> >   the (incoming exec) migration fails.
> >
> >   Fix by retrying on such a case.
>
> Maybe a better solution would be to introduce qemu_{f,}{read,write},
> which handle EINTR and partial reads/writes.

The migration code does not care about partial reads/writes (at this level). 
Data is read /written to/from a buffer. When needed/available we retry.

I can introduce qemu_{f,}{read,write} which only takes care of EINTR (by 
retrying) but the caller would have to handle partial reads/writes (and EAGAIN). 
Would that be helpful ?

Thanks,
    Uri.