[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] Add/Fix command-line checks for smbios options
From: |
Alex Williamson |
Subject: |
[Qemu-devel] Re: [PATCH] Add/Fix command-line checks for smbios options |
Date: |
Thu, 28 May 2009 12:02:03 -0600 |
On Thu, 2009-05-28 at 13:53 -0400, Beth Kon wrote:
> - One type 4 table is required per cpu. Add a check for this.
> - Fix check for smbios file.
>
> Signed-off-by: Beth Kon <address@hidden>
> --
>
> diff --git a/hw/smbios.c b/hw/smbios.c
> index ced90ce..2bc5c67 100644
> --- a/hw/smbios.c
> +++ b/hw/smbios.c
> @@ -40,9 +40,19 @@ struct smbios_table {
>
> static uint8_t *smbios_entries;
> static size_t smbios_entries_len;
> +static int smbios_type4_count = 0;
> +
> +void smbios_validate_table(void) {
static?
> + if (smbios_type4_count && smbios_type4_count != smp_cpus) {
> + fprintf(stderr,
> + "Number of SMBIOS Type 4 tables must match cpu count.\n");
extra space.
Looks ok otherwise. Thanks,
Alex