Re: [Qemu-devel] Re: [PATCH] run vnc without sdl

[Avi Kivity]

Anthony Liguori wrote:
> Glauber Costa wrote:
> > commit f92f8afebe038a4eae9ad90a140c9529f94919a6
> > "Eliminate --disable-gfx-check and make VNC default when SDL not 
> > available"
> > broke usage of vnc. Passing -vnc <something> now fails because it 
> > cannot initialize
> > SDL.
> >
> > Signed-off-by: Glauber Costa <address@hidden>
> >   
>
> What do you think about the attached?  My goal with the original 
> refactoring was to more cleanly separate things that's why I didn't 
> want to introduce the !vnc_display.
>
> Ideally, we could make the various display states register themselves 
> and completely eliminate the #ifdefs...

IMO we should not mix bug fixes with refactoring.  Ideally Glauber's fix 
should have been committed followed by this patch.  If the refactoring 
introduces a new regression, we can then safely revert it.

--
error compiling committee.c: too many arguments to function