Re: [Qemu-devel] [PATCH 02/15] S3C system on chip integrated peripheral device state header

[Vincent Sanders]

On Sat, May 16, 2009 at 12:33:12AM +0200, Jean-Christophe PLAGNIOL-VILLARD 
wrote:
> > +    uint32_t tclk1; /* second timer clock source frequency */
> > +
> > +    /* GPIO block */
> > +    uint32_t gpio_reg[47];
> > +
> > +    /* Realtime clock */
> > +    uint8_t rtc_reg[19];
> > +
> > +    /* i2c */
> > +    struct s3c24xx_i2c_state_s *iic;
> > +    
> > +    /* Timers, (Specifically timer4) */
> > +    uint32_t timers_reg[17];
> it will be better to define a struct with the timers_reg content
> same with the other arry

I had a good hard look at this and decided you were right. I have
restructured all the SOC devices to be completely self contained. I
just posted the new series against git head, it looks a fair bit
neater.

-- 
Regards Vincent
http://www.kyllikki.org/