[Qemu-devel] Re: [COMMIT e20a8df] Compile fdc, escc and SCSI controllers only once

[Jan Kiszka]

Anthony Liguori wrote:
> From: Blue Swirl <address@hidden>
> 
> Signed-off-by: Blue Swirl <address@hidden>
> 
> diff --git a/Makefile.hw b/Makefile.hw
> index 87675fd..6da37a9 100644
> --- a/Makefile.hw
> +++ b/Makefile.hw
> @@ -21,7 +21,13 @@ OBJS+= fw_cfg.o
>  OBJS+= watchdog.o
>  OBJS+= nand.o ecc.o
>  
> -OBJS+= m48t59.o
> +OBJS+= m48t59.o escc.o
> +
> +# PC style devices
> +OBJS+= fdc.o 

This breaks archs that do not come with DMA_* implementations. At least
ARM no longer links.

  LINK  arm-softmmu/qemu-system-arm
../libhw64/libqemuhw64.a(fdc.o): In function `fdctrl_stop_transfer':
/data/qemu/hw/fdc.c:1086: undefined reference to `DMA_release_DREQ'
[...]

Jan

signature.asc
Description: OpenPGP digital signature