qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [STABLE][PATCH 0/4] Rebase more aio dma cancellation wo


From: Avi Kivity
Subject: [Qemu-devel] Re: [STABLE][PATCH 0/4] Rebase more aio dma cancellation work
Date: Thu, 14 May 2009 14:28:01 +0300
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Mark McLoughlin wrote:
Hi,
        We've a report of F11 qemu segfaulting when using read-only
images here:

   https://bugzilla.redhat.com/497170

        Looking at the current code in stable, there is clearly some
borkage:

  - No error handling in bdrv_aio_rw_vector()

  - No error handling in dma_bdrv_cb()/dma_bdrv_io()

  - VectorTranslationState is leaked by bdrv_aio_rw_vector_cb()

  - dma_aio_cancel() is cancelling the wrong aio

       The rest of Avi's aio cancellation patches actually fixes all
these problems. Please apply to stable.

It's a little sad that we have to apply such a non trivial patchset to stable, but I see no way around it. At least it has seen extensive testing in the main branch and in qemu-kvm.git.

(Mark, you have to add your signoff if you're submitting a patch, even if you've done no changes to it at all)

--
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]