[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/4] pci config space emulation clean up TAKE 4
From: |
Isaku Yamahata |
Subject: |
[Qemu-devel] [PATCH 0/4] pci config space emulation clean up TAKE 4 |
Date: |
Wed, 13 May 2009 16:50:48 +0900 |
This patch series is 4th try for cleaning up pci config space emulation.
Making it table driven with mask and callback.
And this time, I converted pci device to use callback.
Note on pci device conversion:
- cirrus_vga.c
pci_cirrus_vga_config_write() allways called
cirrus_update_memory_access().
By grepping the code roughly I concluded it is unnecessary.
But I'm not very certain. At least it seems working with my environment.
- wdt_i6300esb.c
From the code, ESB_CONFIG_REG and ESB_LOCK_REG has only 3bit is valid
and other bits are read only to 0. But I'm not sure it's correct.
Changes from v3
- changed callback signature
- converted pci device
thanks,
Isaku Yamahata (4):
vmware_vga: clean up
qemu: make default_write_config use mask table
pci: pci_default_config_write() clean up.
pci/config: convert pci configuration space handler to use callback.
hw/acpi.c | 11 +-
hw/cirrus_vga.c | 13 +-
hw/gt64xxx.c | 13 +--
hw/pci.c | 398 +++++++++++++++++++++++++++++++++++-----------------
hw/pci.h | 115 +++++++++++++++-
hw/piix_pci.c | 18 ++-
hw/vga.c | 10 +-
hw/vmware_vga.c | 2 +-
hw/wdt_i6300esb.c | 66 ++++-----
9 files changed, 440 insertions(+), 206 deletions(-)