Re: [Qemu-devel] [RFC] New device API

[Anthony Liguori]

Paul Brook wrote:
> The attached patch is my attempt at a new internal API for device creation in 
> qemu.
>   

Instead of recreating constructors, I think we should just use GCC's 
constructor attribute.  This gives us ordering which will be important 
when dealing with buses.

I think the layering is not quite right with qdev.

Not all devices fit into the parameters of register_mmio/connect_irq.  
When dealing with bus devices (like PCI devices), I think you really 
have to model the constructs that the bus expose.  Note, this starts to 
look very similar to the Linux kernel's layered device model.

For instance, the following makes sense to me (from an x86 perspective):

Device              <- for devices connected directly to the 
northbridge/southbridge
 - raise_interrupt(0..255)
 - lower_interrupt(0..255)
 - register_mmio
 - register_pio
 - read_memory
 - write_memory


A PCI controller is a Device, but it introduces the concept of 
PCIDevice.  This is:

PCIDevice
 - raise_link(A|B|C|D)
 - lower_link(A|B|C|D)
 - register_io_region(IO|MEM, BAR, size)
 - read_memory
 - write_memory

A SCSI controller is a PCIDevice, but it introduces the concept of 
SCSIDevice.  This is:

SCSIDevice
 - send_cdb()
 - recv_cdb()

And so forth.  Virtio is a bus, ISA is a bus, etc. etc.

Regards,

Anthony Liguori