qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 7/8] Introduce reset notifier order


From: Jan Kiszka
Subject: [Qemu-devel] Re: [PATCH 7/8] Introduce reset notifier order
Date: Sat, 02 May 2009 02:05:07 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Paul Brook wrote:
> On Friday 01 May 2009, Jan Kiszka wrote:
>> Add the parameter 'order' to qemu_register_reset and sort callbacks on
>> registration. On system reset, callbacks with lower order will be
>> invoked before those with higher order. Update all existing users to the
>> standard order 0.
>>
>> Note: At least for x86, the existing users seem to assume that handlers
>> are called in their registration order. Therefore, the patch preserves
>> this property. If someone feels bored, (s)he could try to identify this
>> dependency and express it properly on callback registration.
> 
> Why do we need this? Why isn't creation order good enough?

At latest when properly deregistering reset handlers again on device
unplug, the registration order is no longer a static thing, manifested
in the code organization - which can also break due to refactoring, BTW.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]