[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2 |
Date: |
Sun, 26 Apr 2009 16:41:18 +0200 |
User-agent: |
Mutt/1.3.28i |
On Sun, Apr 26, 2009 at 05:14:03PM +0300, Avi Kivity wrote:
> Christoph Hellwig wrote:
> >Maybe it's time to make use of sparse's endianess annotations in qcow2
> >to prevent further problems like this one
>
> I'd much prefer strong type checking at compile time:
sparse has strong typechecking at compiletime for the __bitwise types,
although you need the special sparse compiler to parse the annotations
:)
And the big advantage is that qemu already has the infrastructure for
it, while for your new structs you'd need various new helpers, including
for comparisms of disk endian types, etc.