Re: [Qemu-devel] [PATCH 1/6] Allow multiple monitor devices (v2)

[Avi Kivity]

Anthony Liguori wrote:
> Avi Kivity wrote:
> > (qemu) notify enospace on
> > (qemu) notify vnc-connect on
> > (qemu)
> > notification: vnc connection ...
> > (qemu) notify migration-completion on
> > (qemu) migrate -d ...
> > notification: enospc on ide0-0
> > (qemu) migrate_cancel
> > notification: migration cancelled
> > (qemu) migrate -d ...
> > (qemu)
> > notification: migration completed
>
> What are the rules for printing out 'notification'?  Do you want for 
> the end of the buffer to be '\n' or '\n(qemu )'?  If so, if I type:
>
> (qemu) f
>
> But don't hit enter, would that suppress notification?

I'd make everything line-oriented.  Anything from the user up to \n is 
buffered and ignored until the \n arrives.

Once the \n arrives, the command is acted upon atomically, either 
completing fully or launching an async notification.

So the rules are: whenever the monitor is idle, a notification can be 
printed out.

--
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.