|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH 02/10] xen: backend driver core |
Date: | Wed, 08 Apr 2009 08:17:03 -0500 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Gerd Hoffmann wrote:
I meant the public stuff too. I don't like having extern variables all over the place.On 04/07/09 21:41, Anthony Liguori wrote:+/* private */ +static TAILQ_HEAD(XenDeviceHead, XenDevice) xendevs = TAILQ_HEAD_INITIALIZER(xendevs); +static int debug = 0;Would be better to have all of this in a structure that had a single static instance. Would be even better if you could avoid requiring the static instance.Huh? Point being? This is just a list head, i.e. a pointer (or two?).
It would be better to have this in a structure that was passed to all of the backend drivers that they then passed as a context. This will become more useful down the road too when we start introducing a common device model and finer grain locking.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |