Re: [Qemu-devel] [PATCH 2/6] change vectored block I/O API to plain iovecs

[Christoph Hellwig]

On Sun, Mar 15, 2009 at 05:07:59PM +0200, Avi Kivity wrote:
>    QEMUStaticIOVector qiov;
> 
>    qemu_static_iovector_init(&qiov, data, len);
>    some_random_function(&qiov.iov, ...);
> 
> Of course we need not to free non-owned iovecs.

That means more wasted space in every iocb, more special cases
needed in the QEMUIOVector to deal with the static allocation special
case, etc.

I still haven't seen an actual benefit of using the QEMUIOVector at that
level.

> They allow dropping two extra parameters, but I agree no huge benefit.  
> I still like them.

I think they are good for the use case of actually dynamically building
iovecs in the dma helper case.  They just aren't the right interface
for the block level API.  Given that no one underneath that API is
going to add more elements to the iovec there's no good reason to
carry the memory allocation details around.