[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Solution for qemu mcast / ipv6?
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] Solution for qemu mcast / ipv6? |
Date: |
Tue, 10 Mar 2009 16:11:37 +0000 |
User-agent: |
KMail/1.9.9 |
Using diff -up makes patches much easier to review.
> @@ -303,6 +303,13 @@ qemu_format_nic_info_str
> vc->model,
> macaddr[0], macaddr[1], macaddr[2],
> macaddr[3], macaddr[4], macaddr[5]);
> + /* copy mac address into struct for quick matching */
> + vc->macaddress[0] = macaddr[0];
> + vc->macaddress[1] = macaddr[1];
> + vc->macaddress[2] = macaddr[2];
> + vc->macaddress[3] = macaddr[3];
> + vc->macaddress[4] = macaddr[4];
> + vc->macaddress[5] = macaddr[5];
> }
This is almost certainly the wrong place to do this.
> Now the question: Is this a proper solution?
No.
> Does it break anything?
Yes.
You can't make any assumptions about MAC addresses. The guest may choose to
use a different MAC address, or it may be acting as a hub/switch and
generating packets from many different MAC addresses.
The bug is in the the mcast socket code. You need to fix that to stop looping
back all the packets.
Paul