[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Revert "Use the host exit syscall for exiting
Re: [Qemu-devel] [PATCH] Revert "Use the host exit syscall for exiting (Lauro Ramos Venancio)."
Sat, 7 Mar 2009 18:10:03 +0200
On Sat, Mar 7, 2009 at 6:08 PM, Paul Brook <address@hidden> wrote:
> On Saturday 07 March 2009, Felipe Contreras wrote:
>> On Sat, Mar 7, 2009 at 4:05 PM, Paul Brook <address@hidden> wrote:
>> > On Saturday 07 March 2009, Felipe Contreras wrote:
>> >> This breaks pthread_join on arm-linux-user.
>> >> /* XXX: should free thread stack and CPU env */
>> >> - sys_exit(arg1);
>> >> + _exit(arg1);
>> > No. You're just reverting an earlier (also incorrect) change.
>> That commit introduced a regression arm-linux-user, I'm just reverting
>> the change.
>> What do you propose? Leaving arm-linux-user broken is not good.
> It's broken both after your patch, you're just exchanging one bit of
> brokenness for another. The solution is to fix it properly, like I already
Cool, I confirm your patch also fixes the issue.