qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Fix cpuid KVM crash on i386


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Fix cpuid KVM crash on i386
Date: Thu, 05 Mar 2009 13:03:07 -0600
User-agent: Thunderbird 2.0.0.19 (X11/20090105)

Lubomir Rintel wrote:
Cpuid should return into vec, not overwrite past address in count.
Changeset 6565 broke this.

Applied to both stable and trunk.  Thanks.

Regards,

Anthony Liguori

Signed-off-by: Lubomir Rintel <address@hidden>

Index: target-i386/helper.c
===================================================================
--- target-i386/helper.c        (revision 6676)
+++ target-i386/helper.c        (working copy)
@@ -1418,10 +1418,10 @@
 #else
     asm volatile("pusha \n\t"
                  "cpuid \n\t"
-                 "mov %%eax, 0(%1) \n\t"
-                 "mov %%ebx, 4(%1) \n\t"
-                 "mov %%ecx, 8(%1) \n\t"
-                 "mov %%edx, 12(%1) \n\t"
+                 "mov %%eax, 0(%2) \n\t"
+                 "mov %%ebx, 4(%2) \n\t"
+                 "mov %%ecx, 8(%2) \n\t"
+                 "mov %%edx, 12(%2) \n\t"
                  "popa"
                  : : "a"(function), "c"(count), "S"(vec)
                  : "memory", "cc");










reply via email to

[Prev in Thread] Current Thread [Next in Thread]