[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [RESEND] Re: [Qemu-devel] [6443] Enabled building of x86_64
From: |
malc |
Subject: |
Re: [PATCH] [RESEND] Re: [Qemu-devel] [6443] Enabled building of x86_64 code on Mac OS X (Alexander Graf) |
Date: |
Sun, 22 Feb 2009 22:15:39 +0300 (MSK) |
On Sun, 22 Feb 2009, Andreas F?rber wrote:
[..snip..]
> > > bsd="yes"
> > > darwin="yes"
> > > +# on Leopard most of the system is 32-bit, so we have to ask the kernel
> > > it if we can run 64-bit userspace code
> > > +is_x86_64=`sysctl -n hw.optional.x86_64`
> >
> > This results in an error message on OSX/ppc:
> >
> > second level name optional in hw.optional.x86_64 is invalid
> >
> > The attached patch silences this error output.
> >
> > Andreas
> > <qemu-x64-ppc.diff>
>
> My patch still applies cleanly against r6638. Please apply.
>
> It's trivial, but in any case:
>
>
> Silence x64 check on OSX/ppc.
>
> The check for x86_64 on Mac OS X results in an error message on ppc:
>
> second level name optional in hw.optional.x86_64 is invalid
>
> Suppress this message by redirecting error output.
>
> Signed-off-by: Andreas Faerber <address@hidden>
> ---
>
> diff --git a/configure b/configure
> index c3fbbbe..dffed79 100755
> --- a/configure
> +++ b/configure
> @@ -244,7 +244,7 @@ Darwin)
> bsd="yes"
> darwin="yes"
> # on Leopard most of the system is 32-bit, so we have to ask the kernel it if
> we can run 64-bit userspace code
> -is_x86_64=`sysctl -n hw.optional.x86_64`
> +is_x86_64=`sysctl -n hw.optional.x86_64 2>/dev/null`
> if [ "$is_x86_64" = "1" ]; then
> cpu=x86_64
> fi
>
>
It does silence it, but it will also silence any useful warning/error
messages should there be any, perhaps there's some other way?
--
mailto:address@hidden