qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] SH: Improve the interrupt controller


From: Jean-Christophe PLAGNIOL-VILLARD
Subject: Re: [Qemu-devel] SH: Improve the interrupt controller
Date: Fri, 20 Feb 2009 04:06:57 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On 14:05 Thu 12 Feb     , Vladimir Prus wrote:
> On Sunday 08 February 2009 21:57:25 address@hidden wrote:
> > Hi, Vladimir.
> > 
> > I managed to make the code working.
> > r2d boot, SCI and CF working, and /proc/interrupts increases.
> > 
> > Essential points modified are below.
> > 1. sh_intc_init() caller/callee mismatch.
> > 2. nobody calls sh_intc_set_irl_priorities()
> > 3. INTC_MODE_DUAL_SET/CLR swapped
> > I'm not sure 3 in your patch is on purpose or not.
> > 
> > Attached patch is a diff against rev#6563.
> > This is yours + my small fixes, which are..
> > - Above three
> > - sh_intc_set_irl_priorities() has switched to 
> > sh_intc_init_irl_priorities().
> > - sh_intc_set_irl()'s enable hack removed.
> > - indent,tab/space,brace changed (to what looks like code around)
> > - reduce INTC_A7() usage
> > - some others.
> 
> Hi Yoshii,
> I have replaced my original patch with your patch in my patch set, and 
> adjusted
> sh7785 emulation for your changes. It works, but only after I re-do the
where can we found this famous sh7785 patch set?

Best Regards,
J.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]