On Fri, Feb 13, 2009 at 8:23 AM, Jamie Lokier <address@hidden> wrote:
Marc.. this is quite a serious bug you've reported. Is there a
reason you didn't report it earlier?
Because I only started hitting that bug a couple weeks ago after
having upgraded to a buggy kvm version.
Is there a way to restructure the code and/or how it works so it's
more clearly correct?
I am seriously concerned about the general design of qcow2. The code
base is more complex than it needs to be, the format itself is
susceptible to race conditions causing cluster leaks when updating
some internal datastructures, it gets easily fragmented, etc.
I am considering implementing a new disk image format that supports
base images, snapshots (of the guest state), clones (of the disk
content); that has a radically simpler design & code base; that is
always consistent "on disk"; that is friendly to delta diffing (ie.
space-efficient when used with ZFS snapshots or rsync); and that makes
use of checksumming & replication to detect & fix corruption of
critical data structures (ideally this should be implemented by the
filesystem, unfortunately ZFS is not available everywhere :D).
I believe the key to achieve these (seemingly utopian) goals is to
represent a disk "image" as a set of sparse files, 1 per
snapshot/clone.