qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old chang


From: Consul
Subject: Re: [Qemu-devel] qcow2 corruption observed, fixed by reverting old change
Date: Thu, 12 Feb 2009 14:57:12 -0800
User-agent: Thunderbird 2.0.0.19 (Windows/20081209)

Jamie Lokier wrote:

It was just for clarity.  If there are any bugs it's more likely to be
truncation on a 32 bit host :-)

Maybe not a proper fix, do you see the same "corruption" with this patch?
I don't know if it causes any memory leaks, but it certainly clears the segfaults while running my old qcow2 windows images. Perhaps this is a wrong place to free() or it needs a condition?

$ svn diff block.c
Index: block.c
===================================================================
--- block.c     (revision 6618)
+++ block.c     (working copy)
@@ -1263,7 +1263,7 @@
     if (!s->is_write) {
         qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
     }
-    qemu_free(s->bounce);
+    //qemu_free(s->bounce);
     s->this_aiocb->cb(s->this_aiocb->opaque, ret);
     qemu_aio_release(s->this_aiocb);
 }





reply via email to

[Prev in Thread] Current Thread [Next in Thread]