[Qemu-devel] Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filtering

[Alex Williamson]

On Fri, 2009-02-06 at 07:47 +0000, Mark McLoughlin wrote:
> On Thu, 2009-02-05 at 21:51 -0700, Alex Williamson wrote:
> > Here are a couple issues I'm still pondering:
> >  - Is the fd_rx_filter() interface sufficiently generic
> >  - Should vlan_set_hw_rx_filter() live in net.c or elsewhere
> >  - Is it ok to call fd_rx_filter() against all the vlan clients.  I
> >    exit on the first one, which covers the simple config.
> 
> All of these are related to the problem that we're trying to add
> optimizations for the simple config (i.e. one NIC associated with one
> tap interface) without any clean representation of the simple config in
> the API.
> 
> It's not strictly needed in this case - the VLAN API for setting filters
> could aggregate the filters of all VLAN clients - but what you really
> want is to only have the filter apply if virtio-net is paired with a tap
> interface.

Yes, or more precisely, it should only be applied if there are exactly
two devices on the vlan, and the "other" device implements fd_rx_filter.
I'll enforce that in the code.  Thanks,

Alex