Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(

[Daniel P. Berrange]

On Tue, Feb 03, 2009 at 06:31:16AM -0600, Anthony Liguori wrote:
> Avi Kivity wrote:
> >Anthony Liguori wrote:
> >>Robert Riebisch wrote:
> >>>Hi!
> >>>
> >>>Unfortunately Win32 binaries built from QEMU SVN don't run on Windows
> >>>2000 anymore, because of missing DLL entry points in `ws2_32.dll'.
> >>>  
> >>
> >>Unfortunately, win2k is so old at this point, that I don't know that 
> >>it's worth jumping through hoops to support.
> >>
> >>If someone can come up with a simple patch (with appropriately 
> >>licensed code), then I'd be happy to apply it.  Otherwise, I don't 
> >>think not supporting win2k as a host is a huge loss.
> >>
> >
> >There is in fact a signed-off two-liner still in the thread:
> 
> "but it requires copyrighted file `Wspiapi.h' from MSVC2005, because 
> MinGW doesn't provide such a file."
> 
> So if Wspiapi.h carries a GPL compatible license, it's fine to include.  
> The patch lacks Wspiapi.h though so it'll break the build on mingw.

Well MinGW already builds fine with getaddrinfo(), so no need for a GPL
header providing Wspiapi.h there. Since this is only needed for a few
Win builds, why not just make the include conditional on whether that 
header actually exists. eg

#ifdef HAVE_WSPIAPI_H
#include <Wspiapi.h>
#endif

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|