qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] MTRR support on x86, part 2


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] MTRR support on x86, part 2
Date: Thu, 29 Jan 2009 13:48:20 -0600
User-agent: Thunderbird 2.0.0.19 (X11/20090105)

Carl-Daniel Hailfinger wrote:
On 29.01.2009 18:02, Anthony Liguori wrote:
Carl-Daniel Hailfinger wrote:
Load and save MTRR state together with machine state.

Add support for the MTRRcap MSR which is used by the latest Bochs BIOS
and some operating systems.

Fix a typo in ext2_feature_name.

With this patch, MTRR emulation should be good enough to not trigger any
sanity checks in well behaved BIOS/kernel code.
Some corner cases for BIOS/firmware usage remain to be implemented, but
that can be deferred to another patch.
Also, MTRR accesses on hardware not supporting MTRRs should cause #GP.
That can be enforced by another patch as well.

Signed-off-by: Carl-Daniel Hailfinger
<address@hidden>

Thanks for applying the patch!

Index: target-i386/helper.c
===================================================================
--- target-i386/helper.c    (Revision 6461)
+++ target-i386/helper.c    (Arbeitskopie)
@@ -55,7 +55,7 @@
     };
     static const char *ext2_feature_name[] = {
        "fpu", "vme", "de", "pse", "tsc", "msr", "pae", "mce",
-       "cx8" /* AMD CMPXCHG8B */, "apic", NULL, "syscall", "mttr",
"pge", "mca", "cmov",
+       "cx8" /* AMD CMPXCHG8B */, "apic", NULL, "syscall", "mtrr",
"pge", "mca", "cmov",
As best as I can tell, there is no change here.  I removed it from the
diff and applied the rest.

It was mtTr, but it should have been mtRr (emphasis mine).

Yeah, sorry. In general, it's better to split multiple fixes into multiple patches to make it clear. I should have bounced the patch instead of removing that chunk though. Then my mistake would have been more obvious. Sorry again for that.

Regards,

Anthony Liguori

Regards,
Carl-Daniel






reply via email to

[Prev in Thread] Current Thread [Next in Thread]