qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 7/7] Add tight encoding (jpeg) to vnc.c


From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH 7/7] Add tight encoding (jpeg) to vnc.c
Date: Thu, 29 Jan 2009 09:17:54 -0600
User-agent: Thunderbird 2.0.0.19 (X11/20090105)

Alexander Graf wrote:
Because we can now speak the tight protocol, let's use it to
transmit jpeg data to the client!

This patch adds a really easy implementation of the jpeg tight
encoding. Tight in general can do a lot more, but let's take small
steps here and see how things perform.

Signed-off-by: Alexander Graf <address@hidden>

I don't really like the idea of taking this. Tight is supported by a lot of clients and is usually very high on the preferred list. However, most servers do not enable jpeg compression by default because it's lossy.

If we implement Tight and then use jpeg by default, for most clients, the default is going to be lossy encoding. While lossy isn't so bad for high detailed images (like pictures), it's pretty terrible for simple, high contrast images (like windows in a desktop).

TightVNC has some sophisticated heuristics for determining whether to use jpeg or not (when it's enabled). I think that sort of heuristic is a prerequisite for enabling tight's jpeg support.

FWIW, Tight essentially does hextile encoding but adds zlib compression. That's probably a better place to start as it should outperform hextile while remaining lossless.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]