[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/7] Make vnc buffer big-chunk aware
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 4/7] Make vnc buffer big-chunk aware |
Date: |
Thu, 29 Jan 2009 12:24:55 +0100 |
Currently writing to buffers is protected by buffer_reserve.
Unfortunately, is reserves at most 1024 bytes more than we currently
have, so if we want to write a 2048 bytes chunk, we overwrite
random memory.
This patch addresses this in a pretty dumb but easy way.
Signed-off-by: Alexander Graf <address@hidden>
---
vnc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vnc.c b/vnc.c
index 4b17f85..d0d9580 100644
--- a/vnc.c
+++ b/vnc.c
@@ -592,7 +592,7 @@ static int vnc_listen_poll(void *opaque)
static void buffer_reserve(Buffer *buffer, size_t len)
{
- if ((buffer->capacity - buffer->offset) < len) {
+ while ((buffer->capacity - buffer->offset) < len) {
buffer->capacity += (len + 1024);
buffer->buffer = qemu_realloc(buffer->buffer, buffer->capacity);
if (buffer->buffer == NULL) {
--
1.6.0.2
- [Qemu-devel] [PATCH 0/7] Add tight support to VNC, Alexander Graf, 2009/01/29
- [Qemu-devel] [PATCH 1/7] Split VNC defines to vnc.h, Alexander Graf, 2009/01/29
- [Qemu-devel] [PATCH 2/7] Use VNC protocol defines, Alexander Graf, 2009/01/29
- [Qemu-devel] [PATCH 3/7] Fix invalid #if in vnc.c when debugging is enabled, Alexander Graf, 2009/01/29
- [Qemu-devel] [PATCH 4/7] Make vnc buffer big-chunk aware,
Alexander Graf <=
- [Qemu-devel] [PATCH 5/7] Split vnc authentication code, Alexander Graf, 2009/01/29
- [Qemu-devel] [PATCH 6/7] Add tight protocol awareness to vnc.c, Alexander Graf, 2009/01/29
- [Qemu-devel] [PATCH 7/7] Add tight encoding (jpeg) to vnc.c, Alexander Graf, 2009/01/29
- [Qemu-devel] Re: [PATCH 7/7] Add tight encoding (jpeg) to vnc.c, Anthony Liguori, 2009/01/29
- Re: [Qemu-devel] Re: [PATCH 7/7] Add tight encoding (jpeg) to vnc.c, Stefano Stabellini, 2009/01/29
- Re: [Qemu-devel] Re: [PATCH 7/7] Add tight encoding (jpeg) to vnc.c, Anthony Liguori, 2009/01/29
- [Qemu-devel] Re: [PATCH 6/7] Add tight protocol awareness to vnc.c, Anthony Liguori, 2009/01/29
- [Qemu-devel] Re: [PATCH 6/7] Add tight protocol awareness to vnc.c, Alexander Graf, 2009/01/29
- [Qemu-devel] Re: [PATCH 6/7] Add tight protocol awareness to vnc.c, Anthony Liguori, 2009/01/29
- [Qemu-devel] Re: [PATCH 4/7] Make vnc buffer big-chunk aware, Anthony Liguori, 2009/01/29