qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] expose paravirt feature list to cpuid


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH] expose paravirt feature list to cpuid
Date: Wed, 28 Jan 2009 13:50:09 +0000
User-agent: KMail/1.9.9

> +#ifdef KVM_CPUID_SIGNATURE
> +    /* Paravirtualization CPUIDs */
> +    memcpy(signature, "KVMKVMKVM\0\0\0", 12);
> +    pv_ent->ebx = signature[0];
> +    pv_ent->ecx = signature[1];
> +    pv_ent->edx = signature[2];

This is broken on big-endian hosts.

I realise this code is currently only enabled for x86 hosts, however there's a 
good chance we'll want to implement something similar for normal qemu. At 
minimum it needs a comment saying that it's potentially broken.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]