[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Use broadcast address for slirp dhcp replies
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] Use broadcast address for slirp dhcp replies |
Date: |
Sat, 24 Jan 2009 19:16:32 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Jan 20, 2009 at 04:33:31PM +0200, Avi Kivity wrote:
> Windows Vista drops unicast dhcp replies to its yet-unconfigured address,
> so use a broadcast address. This behaviour is allowed by the RFC.
>
> Signed-off-by: Avi Kivity <address@hidden>
Thanks, applied.
> ---
> slirp/bootp.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/slirp/bootp.c b/slirp/bootp.c
> index bf704ab..ca177f4 100644
> --- a/slirp/bootp.c
> +++ b/slirp/bootp.c
> @@ -191,6 +191,8 @@ static void bootp_reply(struct bootp_t *bp)
> rbp->bp_yiaddr = daddr.sin_addr; /* Client IP address */
> rbp->bp_siaddr = saddr.sin_addr; /* Server IP address */
>
> + daddr.sin_addr.s_addr = 0xffffffffu;
> +
> q = rbp->bp_vend;
> memcpy(q, rfc1533_cookie, 4);
> q += 4;
> --
> 1.6.0.6
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net