qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/5] Add target memory mapping API


From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH 1/5] Add target memory mapping API
Date: Mon, 19 Jan 2009 09:49:43 -0600
User-agent: Thunderbird 2.0.0.19 (X11/20090105)

Avi Kivity wrote:
Anthony Liguori wrote:
+        if ((pd & ~TARGET_PAGE_MASK) != IO_MEM_RAM) {
+            if (done || bounce.buffer) {
+                break;
+            }
+ bounce.buffer = qemu_memalign(TARGET_PAGE_SIZE, TARGET_PAGE_SIZE);
+            bounce.addr = addr;
+            bounce.len = l;

I like the bouncing approach. Namely, that it never bounces more than a page at a time. I think that's clever.

I tried to make it as stupid as possible.  Looks like I failed.

Or your version of stupid is my version of clever :-)

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]