[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix day of week in mc146818
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix day of week in mc146818 |
|
Date: |
Wed, 14 Jan 2009 22:10:29 +0100 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, Jan 11, 2009 at 03:31:14PM +0100, Hervé Poussineau wrote:
> Hello,
>
> According to mc146818 specification, Day of Week register (#6) is
> between 1 and 7, 1 representing Sunday.
> According C specification, tm_wday field in struct tm is between 0 and
> 6, 0 representing Sunday.
>
> Bit 2 of register B (#11) is named DM (data mode) and specifies if RTC
> stores values in BCD or in binary form.
>
> Attached patch fixes the off by one error and replaces magic value 0x04
> by REG_B_DM.
>
> Signed-off-by: Hervé Poussineau <address@hidden>
>
Thanks, applied.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' address@hidden | address@hidden
`- people.debian.org/~aurel32 | www.aurel32.net