Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option

[Paul Brook]

On Friday 09 January 2009 12:45:47 Trolle Selander wrote:
> +#ifdef TARGET_SPARC
> +    vga_ram_size += (1024 * 1024);
> +#endif

This looks pretty bogus.

> +    if ( vga_ram_size > 16*1024*1024 )
> +    {
> +        fprintf(stderr,"The stdvga/VBE device model currently has no use
> for more than 16 Megs of vram. Video ram reduced to 16M. \n"); +       
> vga_ram_size = 16*1024*1024;

I'm pretty sure this is wrong. VBE alows arbritary sized virtual framebuffers.

Paul