[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/40] Add v{add, sub}{s, u}{b, h, w}s instructi
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH 18/40] Add v{add, sub}{s, u}{b, h, w}s instructions. |
|
Date: |
Sat, 3 Jan 2009 22:13:20 +0100 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Dec 30, 2008 at 07:10:00PM -0800, Nathan Froyd wrote:
>
> Signed-off-by: Nathan Froyd <address@hidden>
> ---
> target-ppc/helper.h | 12 ++++++++++++
> target-ppc/op_helper.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> target-ppc/translate.c | 12 ++++++++++++
> 3 files changed, 70 insertions(+), 0 deletions(-)
>
> diff --git a/target-ppc/helper.h b/target-ppc/helper.h
> index 1d05cb2..4e1c307 100644
> --- a/target-ppc/helper.h
> +++ b/target-ppc/helper.h
> @@ -161,6 +161,18 @@ DEF_HELPER_3(vaddcuw, void, avr, avr, avr)
> DEF_HELPER_3(vsubcuw, void, avr, avr, avr)
> DEF_HELPER_2(lvsl, void, avr, tl);
> DEF_HELPER_2(lvsr, void, avr, tl);
> +DEF_HELPER_3(vaddsbs, void, avr, avr, avr)
> +DEF_HELPER_3(vaddshs, void, avr, avr, avr)
> +DEF_HELPER_3(vaddsws, void, avr, avr, avr)
> +DEF_HELPER_3(vsubsbs, void, avr, avr, avr)
> +DEF_HELPER_3(vsubshs, void, avr, avr, avr)
> +DEF_HELPER_3(vsubsws, void, avr, avr, avr)
> +DEF_HELPER_3(vaddubs, void, avr, avr, avr)
> +DEF_HELPER_3(vadduhs, void, avr, avr, avr)
> +DEF_HELPER_3(vadduws, void, avr, avr, avr)
> +DEF_HELPER_3(vsububs, void, avr, avr, avr)
> +DEF_HELPER_3(vsubuhs, void, avr, avr, avr)
> +DEF_HELPER_3(vsubuws, void, avr, avr, avr)
>
> DEF_HELPER_1(efscfsi, i32, i32)
> DEF_HELPER_1(efscfui, i32, i32)
> diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c
> index 0b44e7c..1468656 100644
> --- a/target-ppc/op_helper.c
> +++ b/target-ppc/op_helper.c
> @@ -2015,6 +2015,52 @@ VARITH(uwm, u32)
> #undef VARITH_DO
> #undef VARITH
>
> +#define VARITHSAT_CASE(type, op, min, max, use_min, use_max, element) \
> + { \
> + type result = (type)a->element[i] op (type)b->element[i]; \
> + if (use_min && result < min) { \
> + result = min; \
> + sat = 1; \
> + } else if (use_max && result > max) { \
> + result = max; \
> + sat = 1; \
> + } \
> + r->element[i] = result; \
> + }
> +
> +#define VARITHSAT_DO(name, op, min, max, use_min, use_max, element) \
> + void helper_v##name (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \
> + { \
> + int sat = 0; \
> + int i; \
> + for (i = 0; i < ARRAY_SIZE(r->element); i++) { \
> + switch (sizeof(r->element[0])) { \
> + case 1: VARITHSAT_CASE(int16_t, op, min, max, use_min, use_max,
> element); break; \
> + case 2: VARITHSAT_CASE(int32_t, op, min, max, use_min, use_max,
> element); break; \
> + case 4: VARITHSAT_CASE(int64_t, op, min, max, use_min, use_max,
> element); break; \
> + } \
> + } \
> + if (sat) { \
> + env->vscr |= (1 << VSCR_SAT); \
> + } \
> + }
> +#define VARITHSAT_SIGNED(suffix, element, min, max) \
> + VARITHSAT_DO(adds##suffix##s, +, min, max, 1, 1, element) \
> + VARITHSAT_DO(subs##suffix##s, -, min, max, 1, 1, element)
> +#define VARITHSAT_UNSIGNED(suffix, element, max) \
> + VARITHSAT_DO(addu##suffix##s, +, 0, max, 0, 1, element) \
> + VARITHSAT_DO(subu##suffix##s, -, 0, max, 1, 0, element)
> +VARITHSAT_SIGNED(b, s8, INT8_MIN, INT8_MAX)
> +VARITHSAT_SIGNED(h, s16, INT16_MIN, INT16_MAX)
> +VARITHSAT_SIGNED(w, s32, INT32_MIN, INT32_MAX)
> +VARITHSAT_UNSIGNED(b, u8, UINT8_MAX)
> +VARITHSAT_UNSIGNED(h, u16, UINT16_MAX)
> +VARITHSAT_UNSIGNED(w, u32, UINT32_MAX)
> +#undef VARITHSAT_CASE
> +#undef VARITHSAT_DO
> +#undef VARITHSAT_SIGNED
> +#undef VARITHSAT_UNSIGNED
> +
> #define VAVG_DO(name, element, etype) \
> void helper_v##name (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \
> { \
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 5c13ed2..7a6c6e4 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -6301,6 +6301,18 @@ GEN_VXFORM(vslo, 6, 16);
> GEN_VXFORM(vsro, 6, 17);
> GEN_VXFORM(vaddcuw, 0, 6);
> GEN_VXFORM(vsubcuw, 0, 22);
> +GEN_VXFORM(vaddubs, 0, 8);
> +GEN_VXFORM(vadduhs, 0, 9);
> +GEN_VXFORM(vadduws, 0, 10);
> +GEN_VXFORM(vaddsbs, 0, 12);
> +GEN_VXFORM(vaddshs, 0, 13);
> +GEN_VXFORM(vaddsws, 0, 14);
> +GEN_VXFORM(vsububs, 0, 24);
> +GEN_VXFORM(vsubuhs, 0, 25);
> +GEN_VXFORM(vsubuws, 0, 26);
> +GEN_VXFORM(vsubsbs, 0, 28);
> +GEN_VXFORM(vsubshs, 0, 29);
> +GEN_VXFORM(vsubsws, 0, 30);
>
> #define GEN_VXRFORM1(opname, name, str, opc2, opc3) \
> GEN_HANDLER2(name, str, 0x4, opc2, opc3, 0x00000000, PPC_ALTIVEC) \
This patch introduces some new warnings:
/home/aurel32/git/qemu/target-ppc/op_helper.c: In function ‘helper_vaddsws’:
/home/aurel32/git/qemu/target-ppc/op_helper.c:2122: warning: overflow in
implicit constant conversion
/home/aurel32/git/qemu/target-ppc/op_helper.c:2122: warning: overflow in
implicit constant conversion
/home/aurel32/git/qemu/target-ppc/op_helper.c: In function ‘helper_vsubsws’:
/home/aurel32/git/qemu/target-ppc/op_helper.c:2122: warning: overflow in
implicit constant conversion
/home/aurel32/git/qemu/target-ppc/op_helper.c:2122: warning: overflow in
implicit constant conversion
/home/aurel32/git/qemu/target-ppc/op_helper.c: In function ‘helper_vadduws’:
/home/aurel32/git/qemu/target-ppc/op_helper.c:2125: warning: overflow in
implicit constant conversion
/home/aurel32/git/qemu/target-ppc/op_helper.c: In function ‘helper_vsubuws’:
/home/aurel32/git/qemu/target-ppc/op_helper.c:2125: warning: overflow in
implicit constant conversion
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' address@hidden | address@hidden
`- people.debian.org/~aurel32 | www.aurel32.net
- Re: [Qemu-devel] [PATCH 18/40] Add v{add, sub}{s, u}{b, h, w}s instructions.,
Aurelien Jarno <=