Re: [Qemu-devel] [PATCH 04/40] Add v{add,sub}u{b,h,w}m instructions.

[Aurelien Jarno]

On Tue, Dec 30, 2008 at 07:09:46PM -0800, Nathan Froyd wrote:
> 
> Signed-off-by: Nathan Froyd <address@hidden>
> ---
>  target-ppc/helper.h    |    9 +++++++++
>  target-ppc/op_helper.c |   17 +++++++++++++++++
>  target-ppc/translate.c |    6 ++++++
>  3 files changed, 32 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/target-ppc/helper.h b/target-ppc/helper.h
> index 6b5728c..e69fceb 100644
> --- a/target-ppc/helper.h
> +++ b/target-ppc/helper.h
> @@ -96,6 +96,15 @@ DEF_HELPER_1(fres, i64, i64)
>  DEF_HELPER_1(frsqrte, i64, i64)
>  DEF_HELPER_3(fsel, i64, i64, i64, i64)
>  
> +#define dh_alias_avr ptr
> +#define dh_ctype_avr ppc_avr_t *
> +
> +DEF_HELPER_3(vaddubm, void, avr, avr, avr)
> +DEF_HELPER_3(vadduhm, void, avr, avr, avr)
> +DEF_HELPER_3(vadduwm, void, avr, avr, avr)
> +DEF_HELPER_3(vsububm, void, avr, avr, avr)
> +DEF_HELPER_3(vsubuhm, void, avr, avr, avr)
> +DEF_HELPER_3(vsubuwm, void, avr, avr, avr)
>  DEF_HELPER_1(efscfsi, i32, i32)
>  DEF_HELPER_1(efscfui, i32, i32)
>  DEF_HELPER_1(efscfuf, i32, i32)
> diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c
> index 5d603ba..6d4bd1e 100644
> --- a/target-ppc/op_helper.c
> +++ b/target-ppc/op_helper.c
> @@ -1971,6 +1971,23 @@ target_ulong helper_dlmzb (target_ulong high, 
> target_ulong low, uint32_t update_
>    for (index = ARRAY_SIZE(r->element)-1; index >= 0; index--)
>  #endif
>  
> +#define VARITH_DO(name, op, element)        \
> +void helper_v##name (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)          \
> +{                                                                       \
> +    int i;                                                              \
> +    for (i = 0; i < ARRAY_SIZE(r->element); i++) {                      \
> +        r->element[i] = a->element[i] op b->element[i];                 \
> +    }                                                                   \
> +}
> +#define VARITH(suffix, element)                  \
> +  VARITH_DO(add##suffix, +, element)             \
> +  VARITH_DO(sub##suffix, -, element)
> +VARITH(ubm, u8)
> +VARITH(uhm, u16)
> +VARITH(uwm, u32)
> +#undef VARITH_DO
> +#undef VARITH
> +
>  #undef VECTOR_FOR_INORDER_I
>  #undef HI_IDX
>  #undef LO_IDX
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 4ae780b..a35ff1a 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -6181,6 +6181,12 @@ GEN_HANDLER(name, 0x04, opc2, opc3, 0x00000000, 
> PPC_ALTIVEC)            \
>      tcg_temp_free_ptr(rd);                                              \
>  }
>  
> +GEN_VXFORM(vaddubm, 0, 0);
> +GEN_VXFORM(vadduhm, 0, 1);
> +GEN_VXFORM(vadduwm, 0, 2);
> +GEN_VXFORM(vsububm, 0, 16);
> +GEN_VXFORM(vsubuhm, 0, 17);
> +GEN_VXFORM(vsubuwm, 0, 18);
>  /***                           SPE extension                               
> ***/
>  /* Register moves */
>  
> -- 
> 1.6.0.5
> 
> 
> 
> 

-- 
  .''`.  Aurelien Jarno             | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   address@hidden         | address@hidden
   `-    people.debian.org/~aurel32 | www.aurel32.net