Re: [Qemu-devel] [PATCH] add "serial" parameter to -drive flag

[Blue Swirl]

On 12/23/08, Gleb Natapov <address@hidden> wrote:
> Windows calculates HW "uniqueness" based on a hard drive serial number
>  among other things. The patch allows to specify drive serial number
>  from a command line.
>
>  Signed-off-by: Gleb Natapov <address@hidden>

>  -    snprintf(buf, sizeof(buf), "QM%05d", s->drive_serial);

>  -    snprintf(buf, sizeof(buf), "QM%05d", s->drive_serial);

>  -    snprintf(buf, sizeof(buf), "QM%05d", s->drive_serial);

>  +            sprintf(s->drive_serial_str, "QM%05d", s->drive_serial);

You better watch out, this degrades snprintf to sprintf.