[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/31] Logging code cleanup, take 2
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 00/31] Logging code cleanup, take 2 |
Date: |
Fri, 12 Dec 2008 14:54:26 -0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Fri, Dec 12, 2008 at 06:25:44PM +0200, Blue Swirl wrote:
> On 12/12/08, Eduardo Habkost <address@hidden> wrote:
> > This is a new take of the patches for cleaning up qemu logging/debugging
> > code. The series grow a little, as I've macrofied more #ifdefs on other
> > files. I've also changed the macros to use 'foo(bar, ## __VA_ARGS__)'
> > instead of 'foo(bar, __VA_ARGS__)', as suggested by Anthony.
>
> Do you plan to convert Sparc too?
My initial goal is to improve qemu logging so that we can easily change
the way messages are logged (e.g. add timestamps to the log messages,
or use other logging methods). This debugging code cleanup was just one
step for reaching this goal.
Most of the debugging #ifdefs on target-sparc are using printf()
or fprintf(stderr), and the few 'logfile' occurrences are not easily
converted to a single macro, so I didn't change it (yet).
In addition to logging improvements, the debugging code can be unified.
When that happens, I am sure sparc will be changed.
--
Eduardo
- [Qemu-devel] [PATCH 29/31] hw/ppc4xx_devs.c: LOG_UIC macro, (continued)
- [Qemu-devel] [PATCH 29/31] hw/ppc4xx_devs.c: LOG_UIC macro, Eduardo Habkost, 2008/12/12
- [Qemu-devel] [PATCH 18/31] target-mips/translate.c: LOG_DISAS macro, Eduardo Habkost, 2008/12/12
- [Qemu-devel] [PATCH 20/31] target-ppc/helper.c: LOG_SWTLB macro, Eduardo Habkost, 2008/12/12
- [Qemu-devel] [PATCH 21/31] target-ppc/helper.c: convert commented-out debug code to LOG_SWTLB, Eduardo Habkost, 2008/12/12
- [Qemu-devel] [PATCH 26/31] target-ppc/helper.c: LOG_MMU_STATE macro, Eduardo Habkost, 2008/12/12
- [Qemu-devel] [PATCH 11/31] kqemu.c: kill remaining DEBUG #ifdefs, Eduardo Habkost, 2008/12/12
- [Qemu-devel] [PATCH 27/31] target-ppc/op_helper.c: LOG_SWTLB macro, Eduardo Habkost, 2008/12/12
- [Qemu-devel] [PATCH 17/31] target-cris: replace D(fprintf(logfile, ...)) macros with D_LOG(...), Eduardo Habkost, 2008/12/12
- [Qemu-devel] [PATCH 25/31] target-ppc/helper.c: remaining LOG_BATS & LOG_MMU conversions, Eduardo Habkost, 2008/12/12
- Re: [Qemu-devel] [PATCH 00/31] Logging code cleanup, take 2, Blue Swirl, 2008/12/12
- Re: [Qemu-devel] [PATCH 00/31] Logging code cleanup, take 2,
Eduardo Habkost <=