[Qemu-devel] [PATCH 00/31] Logging code cleanup, take 2

[Eduardo Habkost]

This is a new take of the patches for cleaning up qemu logging/debugging
code. The series grow a little, as I've macrofied more #ifdefs on other
files. I've also changed the macros to use 'foo(bar, ## __VA_ARGS__)'
instead of 'foo(bar, __VA_ARGS__)', as suggested by Anthony.

The patches on this series shouldn't bring any change on the behavior of the
code. They are just replacing #ifdefs with macros with the same behavior.

My long-term plan is to have a propper logging API on qemu, instead of
the global variables 'loglevel' and 'logfile'. These cleanups should
make that work easier, in addition to the code readability improvement.

This series is available on a git repository, at:

  git://github.com/ehabkost/qemu-hacks.git logging-cleanup


I have a git branch where I've added qemu-log.h macros that can become
the logging API, and converted all existing references to the 'logfile'
and 'loglevel' variables to use those macros. I plan to submit that soon,
after testing and polishing it. For those interested, the work-in-progress
branch can be seen at:

  git://github.com/ehabkost/qemu-hacks.git hacking/log-api

---

The following changes since commit 8de24106355d25512a8578ac83dab0c7515575b0:
  aurel32 (1):
        PPC405EP: fix fpga write function

are available in the git repository at:

  git://github.com/ehabkost/qemu-hacks.git logging-cleanup

Eduardo Habkost (31):
      hw/ppc.c: LOG_IRQ macro
      hw/ppc.c: use LOG_IRQ instead of #ifdefs
      hw/ppc.c: LOG_TB macro
      hw/ppc.c: use LOG_TB instead of #ifdefs
      vl.c: LOG_IOPORT macro
      vl.c: use LOG_IOPORT instead of #ifdefs
      kqemu.c: LOG_INT macro
      kqemu.c: use LOG_INT instead of #ifdefs
      kqemu.c: LOG_INT_STATE macro
      kqemu.c: use LOG_INT_STATE instead of #ifdefs
      kqemu.c: kill remaining DEBUG #ifdefs
      target-i386/op_helper.c: LOG_PCALL macro
      target-i386/op_helper.c: LOG_PCALL_STATE macro
      target-i386/op_helper.c: use LOG_PCALL instead of #ifdefs
      target-i386/op_helper.c: use LOG_PCALL/LOG_PCALL_STATE
      target-cris/translate.c: LOG_DIS macro
      target-cris: replace D(fprintf(logfile, ...)) macros with D_LOG(...)
      target-mips/translate.c: LOG_DISAS macro
      target-ppc/helper.c: LOG_MMU macro
      target-ppc/helper.c: LOG_SWTLB macro
      target-ppc/helper.c: convert commented-out debug code to LOG_SWTLB
      target-ppc/helper.c: LOG_BATS macro
      target-ppc/helper.c: LOG_SLB macro
      target-ppc/helper.c: LOG_EXCP macro
      target-ppc/helper.c: remaining LOG_BATS & LOG_MMU conversions
      target-ppc/helper.c: LOG_MMU_STATE macro
      target-ppc/op_helper.c: LOG_SWTLB macro
      target-ppc/translate.c: LOG_DISAS macro
      hw/ppc4xx_devs.c: LOG_UIC macro
      target-alpha/translate.c: LOG_DISAS macro
      linux-user/vm86.c: LOG_VM86 macro

 hw/ppc.c                 |  313 ++++++++++----------------------------------
 hw/ppc4xx_devs.c         |   58 +++------
 kqemu.c                  |   77 ++++-------
 linux-user/vm86.c        |   39 +++---
 target-alpha/translate.c |   28 ++--
 target-cris/helper.c     |   26 +++-
 target-cris/mmu.c        |   12 +-
 target-cris/op_helper.c  |   26 +++--
 target-cris/translate.c  |  289 ++++++++++++++++++++--------------------
 target-i386/op_helper.c  |   57 ++++-----
 target-mips/translate.c  |  116 +++-------------
 target-ppc/helper.c      |  328 +++++++++++++++-------------------------------
 target-ppc/op_helper.c   |   64 +++-------
 target-ppc/translate.c   |   24 ++--
 vl.c                     |   40 +++----
 15 files changed, 532 insertions(+), 965 deletions(-)


-- 
Eduardo