Re: [Qemu-devel] [PATCH 3/4] LSI53C895A: Implement TARGET RESET message

[Paul Brook]

On Monday 08 December 2008, Ryan Harper wrote:
> Linux and Windows send a TARGET RESET message to the device when it fails
> to respond as it expects.  For example, when it tries to select LUN1, which
> we don't support.  This patch is needed to support the Linux sym53c8xx_2
> driver when configured with SYM_CONF_DMA_ADDRESSING_MODE=2
>
> Signed-off-by: Ryan Harper <address@hidden>
>
> diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
> index b36c08c..ac8c5a5 100644
> --- a/hw/lsi53c895a.c
> +++ b/hw/lsi53c895a.c
> @@ -804,6 +804,10 @@ static void lsi_do_msgout(LSIState *s)
>                  goto bad;
>              }
>              break;
> +        case 0x0c: /* TARGET RESET */
> +            DPRINTF("MSG: Target Reset\n");
> +            lsi_soft_reset(s);
> +            break;
>          case 0x20: /* SIMPLE queue */
>              s->current_tag |= lsi_get_msgbyte(s) | LSI_TAG_VALID;
>              DPRINTF("SIMPLE queue tag=0x%x\n", s->current_tag & 0xff);

This looks wrong. The clue is in the name. This should reset the *target* 
device (i.e. the disk) not the host adapter.

Probably also explains why you need the bogus 4th patch.

Paul