Re: [Qemu-devel] [5889] Make struct iovec universally available

[Andreas Färber]

Am 06.12.2008 um 11:30 schrieb Andreas Färber:

> On Mac OS X v10.5 this test results in HAVE_IOVEC 1, but I get the  
> following compilation failure:
>
> gcc -I. -I.. -I/Users/andreas/Q/qemu/target-i386 -I/Users/andreas/Q/ 
> qemu -MMD -MT pc.o -MP -DNEED_CPU_H -D__powerpc__ -D_GNU_SOURCE - 
> D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/Users/andreas/Q/qemu/ 
> tcg -I/Users/andreas/Q/qemu/tcg/ppc -I/Users/andreas/Q/qemu/fpu - 
> DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/Users/andreas/Q/qemu/slirp -O2 -g - 
> fno-strict-aliasing -Wall -Wundef -Wendif-labels -Wwrite-strings - 
> mdynamic-no-pic  -c -o pc.o /Users/andreas/Q/qemu/hw/pc.c
> In file included from /Users/andreas/Q/qemu/hw/virtio-blk.h:17,
>                 from /Users/andreas/Q/qemu/hw/pc.c:36:
> /Users/andreas/Q/qemu/hw/virtio.h:67: error: array type has  
> incomplete element type
> /Users/andreas/Q/qemu/hw/virtio.h:68: error: array type has  
> incomplete element type
> /Users/andreas/Q/qemu/hw/pc.c: In function ‘pc_init1’:
> /Users/andreas/Q/qemu/hw/pc.c:830: warning: large integer implicitly  
> truncated to unsigned type
> make[1]: *** [pc.o] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
> It does not go away even if I #define HAVE_IOVEC 0 in config-host.h.

Some more info:
Commenting the #define out leads to:

gcc -O2 -g -fno-strict-aliasing -Wall -Wundef -Wendif-labels -Wwrite- 
strings -mdynamic-no-pic  -I. -I/Users/andreas/Q/qemu -MMD -MP -MT  
osdep.o -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/ 
Users/andreas/Q/qemu/slirp -c -o osdep.o osdep.c
In file included from qemu_socket.h:22,
                 from osdep.c:48:
/usr/include/sys/socket.h:128: error: redefinition of ‘struct iovec’
make: *** [osdep.o] Error 1


If I don't touch config-host.h (i.e., #define HAVE_IOVEC 1) and add  
#include <sys/socket.h> in virtio.h, then it compiles okay.

Maybe include qemu-socket.h somewhere?

Andreas