[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] IBM PowerPC 4xx 32-bit PCI controller emulation
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] IBM PowerPC 4xx 32-bit PCI controller emulation |
Date: |
Mon, 1 Dec 2008 20:15:48 +0200 |
On 11/26/08, Hollis Blanchard <address@hidden> wrote:
> This PCI controller can be found on a number of 4xx SoCs, including the 440EP.
>
> Signed-off-by: Hollis Blanchard <address@hidden>
> ---
> This isn't yet used by the ppc405 boards qemu emulates, but it could be if
> someone has a 405 firmware/kernel they're able to test with.
The device can't be tested unless it's used by some board.
> +#if 0
> + printf("### %s: devfn %x irq %d -> %d\n", __func__,
> + pci_dev->devfn, irq_num, slot+1);
> +#endif
You could introduce a DPRINTF macro, like for example in slavio_intctl.c.
> + /* Board IRQs 2-5 are connected to UIC IRQs 28-25 */
> + /* XXX Needs some abstracting for boards other than Bamboo. */
> + qemu_set_irq(pic[30-irq_num], level);
> +}
The IRQs should be set up at the board level and then passed to the device.
> + /* XXX register_savevm() */
And register_reset?
- Re: [Qemu-devel] [PATCH] IBM PowerPC 4xx 32-bit PCI controller emulation,
Blue Swirl <=