qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute

From: Jan Kiszka
Subject: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute
Date: Sun, 30 Nov 2008 13:33:55 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 
Avi Kivity wrote:
> Jan Kiszka wrote:
>>> Breaking the standard is what brings us the joys of recently (re)posted
>>> patch for NetBSD and [u]intXX fun.
>>>     
>>
>> I have no problem with calling it 'noreturn' instead.
>>   
> 
> That will break code that wants to use 'noreturn' as a local variable. 
> I think ATTR_NORETURN, while a lot uglier, is safer.

Do you have such code already? Is it exported beyond qemu scope? Then
why not going for our own convention "'noreturn' is reserved as function
attribute"? (And yes, your macro is ugly :) ).

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to
[Prev in Thread] Current Thread [Next in Thread]