Re: [Qemu-devel] [PATCH] ARM: fix usad8 and usada8 instructions

[Laurent Desnogues]

On Wed, Nov 26, 2008 at 12:27 AM, Mans Rullgard <address@hidden> wrote:
> This fixes the destination and accumulator registers for the usad8
> and usada8 instructions.

This patch is correct.

Is this when I should put a "acked-by"?


Laurent

> Signed-off-by: Mans Rullgard <address@hidden>
> ---
>  target-arm/translate.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 186f1d5..305a438 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -6556,12 +6556,12 @@ static void disas_arm_insn(CPUState * env, 
> DisasContext *s)
>                         tmp2 = load_reg(s, rs);
>                         gen_helper_usad8(tmp, tmp, tmp2);
>                         dead_tmp(tmp2);
> -                        if (rn != 15) {
> -                            tmp2 = load_reg(s, rn);
> +                        if (rd != 15) {
> +                            tmp2 = load_reg(s, rd);
>                             tcg_gen_add_i32(tmp, tmp, tmp2);
>                             dead_tmp(tmp2);
>                         }
> -                        store_reg(s, rd, tmp);
> +                        store_reg(s, rn, tmp);
>                         break;
>                     case 0x20: case 0x24: case 0x28: case 0x2c:
>                         /* Bitfield insert/clear.  */
> --
> 1.6.0.4
>
>
>
>